Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not expose crate-private Header struct in public interface #695

Closed
wants to merge 1 commit into from

Conversation

alekitto
Copy link

Commit 4ddcc3a made Header struct internal (crate-private), but is was used in some non-exported functions maked as public. This raises an error while compiling the library.
Marking the functions as crate-private (as the Header struct) fixes the compilation.

@algesten
Copy link
Owner

Hi @alekitto, welcome to ureq!

I'm curious, how do you compile ureq to trigger this error?

@alekitto
Copy link
Author

In one of my projects I needed rustls 0.22 support, so I've included the library explicitly targeting the git repository and it simply failed.

@nponsard
Copy link

nponsard commented Jan 15, 2024

I have the same problem when trying to build a simple program using ureq on the commit 26ed596. Applying the changes of this PR fixes it.

Cargo.toml :

[package]
name = "benchmark-ureq"
version = "0.1.0"
edition = "2021"

[dependencies]
ureq = { git = "https://github.com/algesten/ureq" }

Code :

fn main() {
  let resp = ureq::get("https://www.rust-lang.org/")
    .call()
    .expect("Could not make request");
}

@algesten
Copy link
Owner

Closing since we are moving to 3.x

@algesten algesten closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants